Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite microsoft teams webhook #36397

Merged
merged 28 commits into from
Sep 29, 2024
Merged

rewrite microsoft teams webhook #36397

merged 28 commits into from
Sep 29, 2024

Conversation

tcarmeli1
Copy link
Contributor

@tcarmeli1 tcarmeli1 commented Sep 19, 2024 •
edited
Loading

Status

  • Ready

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-11130

Description

rewrite microsoft teams webhook

Must have

  • Tests
  • Documentation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/MicrosoftTeams/Integrations/MicrosoftTeamsWebhook
   MicrosoftTeamsWebhook.py35294%163–164
TOTAL35294% 

Tests Skipped Failures Errors Time
48 0 💤 0 ❌ 0 🔥 7.309s ⏱️

jbabazadeh
jbabazadeh reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Packs/MicrosoftTeams/Integrations/MicrosoftTeamsWebhook/MicrosoftTeamsWebhook.py Show resolved Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeamsWebhook/MicrosoftTeamsWebhook.py Show resolved Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeamsWebhook/MicrosoftTeamsWebhook.yml Outdated Show resolved Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeamsWebhook/MicrosoftTeamsWebhook.yml Outdated Show resolved Hide resolved
Packs/MicrosoftTeams/ReleaseNotes/1_4_70.md Outdated Show resolved Hide resolved
@ShirleyDenkberg ShirleyDenkberg self-assigned this Sep 29, 2024
@ShirleyDenkberg
Copy link
Contributor

@jbabazadeh Doc review completed.

@tcarmeli1 tcarmeli1 merged commit b59e62d into master Sep 29, 2024
16 checks passed
@tcarmeli1 tcarmeli1 deleted the microsoft-teams-webhook branch September 29, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@jbabazadeh jbabazadeh jbabazadeh approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

@jbabazadeh jbabazadeh

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcarmeli1 @ShirleyDenkberg @jbabazadeh